Clarify push notifs and DM stitching #465
Open
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jhaaaa
commented
Nov 3, 2025
neekolas
reviewed
Nov 4, 2025
jhaaaa
commented
Nov 5, 2025
| Also, you must consider that a welcome message will be sent when a DM conversation is added to the stitched DMs, and you should not send a push for the welcome message because the user already has a conversation with the person. It is just a different DM conversation in the set of DM conversations that are stitched together. These welcome messages are filtered out of streams, but they are not filtered out for the XMTP push notification server, so you must handle these duplicate DM welcomes at the push notification service. | ||
| - While a DM conversation can have multiple topics, each individual message is sent to only one topic. This means you will receive only one push notification per message, not multiple notifications for the same message. Subscribing to all topics just ensures you don't miss a message, regardless of which topic it's sent on. | ||
|
|
||
| - A welcome message will be sent when a DM conversation is added to the stitched DMs, and you should not send a push for the welcome message because the user already has a conversation with the person. It is just a different DM conversation in the set of DM conversations that are stitched together. These welcome messages are filtered out of streams, but they are not filtered out for the XMTP push notification server, so you must handle these duplicate DM welcomes at the push notification service. |
Collaborator
Author
There was a problem hiding this comment.
Add guidance about HOW to do this. For example, how can I know that when I got this push notification in the app, this is a new message, a new conversation, or an old one.
Chat with Benny - he's been thinking about it from the context of agents, where this is a particular kind of pressing problem as well.
Agents want to respond when they get invited to a new conversation. But then, if you have a second instance of the agent, they don't want that one to say, send everyone a, hey, good to meet you message. He probably has some ideas about how to detect this in push notification handlers as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify push notification and DM stitching behavior in understand-push-notifs.mdx to document distinct conversation IDs, per-message single-topic delivery, and DM topic subscription guidance
Update documentation by converting a paragraph into a bullet list in understand-push-notifs.mdx; state that distinct conversation IDs imply distinct topics; state that each message maps to exactly one topic and yields one push notification; add guidance to subscribe to all topics for a DM; retain welcome message handling and resubscribe guidance as bullets with the existing link.
📍Where to Start
Start with the bullet list under push notification behavior in understand-push-notifs.mdx.
Changes since #465 opened
📊 Macroscope summarized 1b24fc8. 0 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.