This repository was archived by the owner on Jul 7, 2025. It is now read-only.
Add filter for unsupported content types without a fallback#128
Open
Add filter for unsupported content types without a fallback#128
Conversation
🦋 Changeset detectedLatest commit: 9336d24 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
neekolas
reviewed
Oct 24, 2023
Contributor
neekolas
left a comment
neekolas
left a comment
There was a problem hiding this comment.
I thought we were just going to handle this in the JS SDK
Contributor
Author
i think the JS SDK should remain an unbiased conduit to the network. that being said, adding this filter to the JS SDK creates issues around message paging. i don't think the added complexity would be worth it. |
neekolas
approved these changes
Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in this PR:
useMessageshook that removes messages with unsupported content types and no fallback contentdisableUnsupportedNoFallbackFilteringoption touseMessageshook to allow for disabling of the filter