Fix FLUX scheduler #2896
Closed
Fix FLUX scheduler #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinxuye
reviewed
Feb 20, 2025
| @@ -416,8 +416,12 @@ def _get_scheduler(model: Any, sampler_name: str): | |||
| @contextlib.contextmanager | |||
| def _reset_when_done(model: Any, sampler_name: str): | |||
| assert model is not None | |||
| name_or_path: Optional[str] = getattr(model, "_name_or_path", None) | |||
| is_flux_sampler = "flux" in name_or_path.casefold() if name_or_path else False | |||
There was a problem hiding this comment.
I think we'd better judge flux by model_spec, so we may set this method to normal function instead of static method. Because we cannot ensure that the model path contains flux.
| scheduler = DiffusionModel._get_scheduler(model, sampler_name) | ||
| if scheduler: | ||
| # When the model is not flux | ||
| should_swap_scheduler = scheduler is not None and not is_flux_sampler |
There was a problem hiding this comment.
Better to name a better one, maybe ignore_setting_scheduler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2832 .