Code cleanup

xstefank · May 5, 2018 · b635708 · b635708
1 parent 33cc809
commit b635708
Show file tree

Hide file tree

Showing 12 changed files with 1 addition and 83 deletions.
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -149,4 +149,3 @@ services:
       - ./data/db:/data/db
     ports:
       - 27017:27017
-    #command: mongod --smallfiles --logpath=/dev/null # --quiet
diff --git a/invoice-service/build.gradle b/invoice-service/build.gradle
@@ -37,7 +37,6 @@ dependencies {
 	compileOnly 'org.projectlombok:lombok:1.16.18'
 
 
-//	compile('org.springframework.boot:spring-boot-starter-data-jpa')
 	compile('org.springframework.boot:spring-boot-starter-web')
 	compileOnly('org.projectlombok:lombok:1.16.18')
 

diff --git a/...rvice/src/main/java/org/learn/eventuate/invoiceservice/domain/service/InvoiceService.java b/...rvice/src/main/java/org/learn/eventuate/invoiceservice/domain/service/InvoiceService.java
@@ -41,7 +41,7 @@ public CompletableFuture<EntityWithIdAndVersion<InvoiceAggregate>> prepareInvoic
     }
 
     public void compensateInvoice(ParticipantFailureInfo failureInfo) {
-        if (failureInfo.getId() == "N/A") {
+        if (failureInfo.getId().equals("N/A")) {
             confirmCompensation(failureInfo.getSagaId());
         }
         aggregateRepository.update(failureInfo.getId(), new CompensateInvoiceCommand(failureInfo));

diff --git a/...vice/src/test/java/org/learn/eventuate/invoiceservice/InvoiceServiceApplicationTests.java b/...vice/src/test/java/org/learn/eventuate/invoiceservice/InvoiceServiceApplicationTests.java
diff --git a/order-service/build.gradle b/order-service/build.gradle
@@ -37,7 +37,6 @@ dependencies {
 	compileOnly 'org.projectlombok:lombok:1.16.18'
 
 
-//	compile('org.springframework.boot:spring-boot-starter-data-jpa')
 	compile('org.springframework.boot:spring-boot-starter-web')
 	compileOnly('org.projectlombok:lombok:1.16.18')
 

diff --git a/...e/src/main/java/org/learn/eventuate/orderservice/command/saga/ProcessShipmentCommand.java b/...e/src/main/java/org/learn/eventuate/orderservice/command/saga/ProcessShipmentCommand.java
@@ -4,7 +4,6 @@
 
 public class ProcessShipmentCommand implements OrderSagaCommand {
 
-
     private ShipmentInfo shipmentInfo;
 
     public ProcessShipmentCommand(ShipmentInfo shipmentInfo) {

diff --git a/...ervice/src/main/java/org/learn/eventuate/orderservice/controller/OrderSagaController.java b/...ervice/src/main/java/org/learn/eventuate/orderservice/controller/OrderSagaController.java
@@ -4,8 +4,6 @@
 import org.learn.eventuate.coreapi.ParticipantFailureInfo;
 import org.learn.eventuate.coreapi.ShipmentInfo;
 import org.learn.eventuate.orderservice.domain.service.OrderSagaService;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RequestMapping;
@@ -18,8 +16,6 @@ public class OrderSagaController {
 
     @Autowired
     public OrderSagaService orderSagaService;
-    private Logger log = LoggerFactory.getLogger(OrderSagaController.class);
-
 
     @RequestMapping(method = RequestMethod.POST, path = "/shipment")
     public String shipmentResponse(@RequestBody ShipmentInfo shipmentInfo) {

diff --git a/...-service/src/test/java/org/learn/eventuate/orderservice/OrderServiceApplicationTests.java b/...-service/src/test/java/org/learn/eventuate/orderservice/OrderServiceApplicationTests.java
diff --git a/...-service/src/test/java/org/learn/eventuate/queryservice/QueryServiceApplicationTests.java b/...-service/src/test/java/org/learn/eventuate/queryservice/QueryServiceApplicationTests.java
diff --git a/shipment-service/build.gradle b/shipment-service/build.gradle
@@ -37,7 +37,6 @@ dependencies {
 	compileOnly 'org.projectlombok:lombok:1.16.18'
 
 
-//	compile('org.springframework.boot:spring-boot-starter-data-jpa')
 	compile('org.springframework.boot:spring-boot-starter-web')
 	compileOnly('org.projectlombok:lombok:1.16.18')
 

diff --git a/...t-service/src/main/java/org/learn/eventuate/shipmentservice/domain/ShipmentAggregate.java b/...t-service/src/main/java/org/learn/eventuate/shipmentservice/domain/ShipmentAggregate.java
@@ -38,7 +38,6 @@ public List<Event> process(PrepareShipmentCommand command) {
     }
 
     public List<Event> process(CompensateShipmentCommand command) {
-        //shipment compensation
         log.info("shipment " + command.getFailureInfo().getId() + " compensated");
 
         return EventUtil.events(new ConfirmShipmentCompensationEvent(command.getFailureInfo().getSagaId(), id));

diff --git a/...ce/src/test/java/org/learn/eventuate/shipmentservice/ShipmentServiceApplicationTests.java b/...ce/src/test/java/org/learn/eventuate/shipmentservice/ShipmentServiceApplicationTests.java
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4,7 +4,6 @@

		public class ProcessShipmentCommand implements OrderSagaCommand {


		private ShipmentInfo shipmentInfo;

		public ProcessShipmentCommand(ShipmentInfo shipmentInfo) {
Expand Down