Skip to content

Commit

Permalink
[SPARK-30654][WEBUI] Bootstrap4 WebUI upgrade
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?
Spark's Web UI is using an older version of Bootstrap (v. 2.3.2) for the portal pages. Bootstrap 2.x was moved to EOL in Aug 2013 and Bootstrap 3.x was moved to EOL in July 2019 (https://github.com/twbs/release). Older versions of Bootstrap are also getting flagged in security scans for various CVEs:

https://snyk.io/vuln/SNYK-JS-BOOTSTRAP-72889
https://snyk.io/vuln/SNYK-JS-BOOTSTRAP-173700
https://snyk.io/vuln/npm:bootstrap:20180529
https://snyk.io/vuln/npm:bootstrap:20160627

I haven't validated each CVE, but it would be nice to resolve any potential issues and get on a supported release.

The bad news is that there have been quite a few changes between Bootstrap 2 and Bootstrap 4. I've tried updating the library, refactoring/tweaking the CSS and JS to maintain a similar appearance and functionality, and testing the UI for functionality and appearance. This is a fairly large change so I'm sure additional testing and fixes will be needed.

### How was this patch tested?
This has been manually tested, but there is a ton of functionality and there are many pages and detail pages so it is very possible bugs introduced from the upgrade were missed. Additional testing and feedback is welcomed. If it appears a whole page was missed let me know and I'll take a pass at addressing that page/section.

Closes apache#27370 from clarkead/bootstrap4-core-upgrade.

Authored-by: Dale Clarke <[email protected]>
Signed-off-by: Gengliang Wang <[email protected]>
  • Loading branch information
clarkead authored and gengliangwang committed Mar 13, 2020
1 parent 6809815 commit 2a4fed0
Show file tree
Hide file tree
Showing 53 changed files with 647 additions and 1,666 deletions.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

879 changes: 6 additions & 873 deletions core/src/main/resources/org/apache/spark/ui/static/bootstrap.min.css
100755 → 100644

Large diffs are not rendered by default.

Large diffs are not rendered by default.

This file was deleted.

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 2a4fed0

Please sign in to comment.