Skip to content

fix INT in cast #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix INT in cast #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
723e8bc
fix INT in cast
mei-rune Aug 31, 2021
b6e8488
fix BOOL in cast
mei-rune Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ast.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2802,13 +2802,18 @@ func (node *SubstrExpr) walkSubtree(visit Visit) error {
// ConvertExpr represents a call to CONVERT(expr, type)
// or it's equivalent CAST(expr AS type). Both are rewritten to the former.
type ConvertExpr struct {
IsCast bool
Expr Expr
Type *ConvertType
}

// Format formats the node.
func (node *ConvertExpr) Format(buf *TrackedBuffer) {
buf.Myprintf("convert(%v, %v)", node.Expr, node.Type)
if node.IsCast {
buf.Myprintf("CAST(%v AS %v)", node.Expr, node.Type)
} else {
buf.Myprintf("convert(%v, %v)", node.Expr, node.Type)
}
}

func (node *ConvertExpr) walkSubtree(visit Visit) error {
Expand Down
18 changes: 17 additions & 1 deletion parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1528,7 +1528,23 @@ func TestConvert(t *testing.T) {
output string
}{{
input: "select cast('abc' as date) from t",
output: "select convert('abc', date) from t",
output: "select CAST('abc' AS date) from t",
},{
input: "select cast('abc' as int) from t",
output: "select CAST('abc' AS int) from t",
},{
input: "select cast('abc' as integer) from t",
output: "select CAST('abc' AS integer) from t",
},{
input: "select cast('abc' as bool) from t",
output: "select CAST('abc' AS bool) from t",
},{
input: "select cast('abc' as boolean) from t",
output: "select CAST('abc' AS boolean) from t",
}, {
input: "select convert('abc', int) from t",
}, {
input: "select convert('abc', integer) from t",
}, {
input: "select convert('abc', binary(4)) from t",
}, {
Expand Down
Loading