Ci test #102
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,7 @@ concurrency: | |
|
|
||
| jobs: | ||
| test: | ||
| runs-on: self-hosted | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: Test NPM Availability | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| test-npm: | ||
| runs-on: self-hosted | ||
| steps: | ||
| - name: Check system info | ||
| run: | | ||
| echo "=== Runner Information ===" | ||
| echo "Hostname: $(hostname)" | ||
| echo "OS: $(uname -a)" | ||
| echo "User: $(whoami)" | ||
| - name: Check npm and node versions | ||
| run: | | ||
| echo "=== NPM and Node Versions ===" | ||
| which npm || echo "npm not found in PATH" | ||
| npm --version || echo "npm command failed" | ||
| which node || echo "node not found in PATH" | ||
| node --version || echo "node command failed" | ||
| - name: List installed packages | ||
| run: | | ||
| echo "=== Checking for npm in common locations ===" | ||
| ls -la /usr/bin/npm 2>/dev/null || echo "/usr/bin/npm not found" | ||
| ls -la /usr/local/bin/npm 2>/dev/null || echo "/usr/local/bin/npm not found" | ||
| which -a npm 2>/dev/null || echo "npm not in PATH" | ||
|
Comment on lines
+1
to
+30
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial Clarify purpose and long-term intent of NPM availability diagnostic workflow. The
If this is a temporary diagnostic workflow for self-hosted runner setup validation, add documentation: # TODO: Review this diagnostic workflow after self-hosted runner setup is complete
# Created: 2025-11-11, Purpose: Verify npm/node availability on self-hosted runners
name: Test NPM Availability # Diagnostic workflow - may be removed after setup validationAdditionally, consider making the workflow fail if npm is not available, to surface configuration issues: - name: Check npm and node versions
run: |
echo "=== NPM and Node Versions ==="
+ set -e # Exit on first error
which npm || (echo "ERROR: npm not found in PATH" && exit 1)
npm --version
which node || (echo "ERROR: node not found in PATH" && exit 1)
node --version🤖 Prompt for AI Agents |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| name: Test Runner Pickup | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - ci-test | ||
|
|
||
| jobs: | ||
| simple-test: | ||
| runs-on: self-hosted | ||
| steps: | ||
| - name: Echo test | ||
| run: | | ||
| echo "Runner picked up the job!" | ||
| echo "Hostname: $(hostname)" | ||
| echo "Date: $(date)" | ||
| echo "User: $(whoami)" | ||
|
Comment on lines
+1
to
+18
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial Clarify purpose and long-term intent of diagnostic workflow. The
If this is a temporary diagnostic workflow for validating the CI migration, consider adding a comment documenting its purpose and planned removal date: # TODO: Remove this diagnostic workflow after validating self-hosted runner setup
# Created: 2025-11-11, Target removal: 2025-12-11
name: Test Runner Pickup # Diagnostic: Self-hosted runner availability test🤖 Prompt for AI Agents |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -22,7 +22,7 @@ concurrency: | |||||
|
|
||||||
| jobs: | ||||||
| changes: | ||||||
| runs-on: self-hosted | ||||||
|
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial Add runner labels to prevent job starvation with matrix strategy. The Consider adding specific runner labels to ensure adequate capacity: changes:
- runs-on: self-hosted
+ runs-on: [self-hosted, linux, x64, test-runner-pool]Then configure a runner group or add a custom label 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| # Required permissions | ||||||
| permissions: | ||||||
| pull-requests: read | ||||||
|
|
@@ -41,7 +41,7 @@ jobs: | |||||
| - '!presto-docs/**' | ||||||
|
|
||||||
| test: | ||||||
| runs-on: self-hosted | ||||||
|
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial Verify self-hosted runner disk space for Maven cache accumulation. The Implement a cache cleanup strategy, such as:
🤖 Prompt for AI Agents |
||||||
| needs: changes | ||||||
| strategy: | ||||||
| fail-fast: false | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Verify self-hosted runner has Docker daemon and registry credentials.
The
presto-coordinator-imagejob builds and pushes Docker images toghcr.io. Ensure self-hosted runners have:ghcr.ioNo Docker-specific runner labels are specified, which could lead to job failures if assigned to runners without Docker support.
Add explicit Docker support labels to the runner specification:
presto-coordinator-image: name: "presto-coordinator-image" needs: "maven-checks" - runs-on: self-hosted + runs-on: [self-hosted, linux, docker, x64]