Rename SchedulingScope -> CallbackDispatchScope, SCHEDULING_KEY -> DISPATCH_KEY - #51
Merged
Merged
Conversation
…SPATCH_KEY Since callback_wrapper (#47 phase 2) the fiber-storage scope carries the (scheduling mode, wrapper) dispatch pair, not just the mode — name the carrier and its key after what they hold. Both are @api private, so the rename is safe. The fiber-storage symbol value follows suit (:claude_agent_sdk_callback_dispatch), comments and CLAUDE.md updated, and the restore local in Query#handle_sdk_mcp_request is now previous_dispatch. No behavior change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QFYekWo9xbMekqyu4Qj6Dk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the v0.25–v0.27 adversarial release audit (fixes landed in 6e4d9c8). Codex's non-blocking design concern: since callback_wrapper (#47 phase 2) the scope object carries an inseparable (scheduling mode, wrapper) dispatch pair, so the name
SchedulingScopeundersells what it invalidates.Pure rename, no behavior change — both names are
@api private:FiberBoundary::SchedulingScope→FiberBoundary::CallbackDispatchScopeFiberBoundary::SCHEDULING_KEY→FiberBoundary::DISPATCH_KEY(fiber-storage symbol value updated to:claude_agent_sdk_callback_dispatchin lockstep)Verification: 1210 examples, 0 failures; RuboCop 64 files, no offenses.
Note: independent of #52 (both branch from 6e4d9c8); whichever merges second has a small mechanical conflict in the shared fiber_boundary.rb/query.rb region — resolve by using the new names inside the extracted helper.
🤖 Generated with Claude Code
https://claude.ai/code/session_019Manwfh1GRrJtQfgTm1dtt