Воронина Веда #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.name = name; | ||
| } | ||
|
|
||
| public void setCover_small(String cover_small) { |
Contributor
There was a problem hiding this comment.
Немного не джава-вэй. camalCaseEverywhere:)
Author
|
Подправила, чуть позже добавляю AutoValue + Moshi + AutoParcel |
| Log.w("ListFragment", "OnCreateView"); | ||
| View rootView = inflater.inflate(R.layout.fragment_list, container, false); | ||
| ButterKnife.bind(this, rootView); | ||
| if (getActivity() instanceof ListProvider && getActivity() instanceof PerformerSelectedListener) { |
Contributor
There was a problem hiding this comment.
Исключение всё же кидать надо, если активити эти интерфейсы не реализует.
| selectionArgs, null, null, sortOrder); | ||
|
|
||
| cursor.setNotificationUri(getContext().getContentResolver(), | ||
| CONTENT_URI); |
There was a problem hiding this comment.
setNotificationUri для чего, если не секрет?
| +");"); | ||
|
|
||
| db.execSQL("CREATE INDEX idx_genres_" + Genre.ID + | ||
| " ON " + GENRES + "(" + Genre.ID + ")"); |
ВСЕ, ЖДУ ОБНОВЛЕНИЙ |
Author
|
Встроенную функцию для журнала не нашла, остальное все вроде поправила |
| mDbOpenHelper = new DBHelper(context); | ||
| } | ||
|
|
||
| public void insertSinger(Singer singer) { |
| public void insertSinger(Singer singer) { | ||
| SQLiteDatabase db = mDbOpenHelper.getWritableDatabase(); | ||
| ContentValues values = createCV(singer); | ||
| db.beginTransaction(); |
There was a problem hiding this comment.
У меня вопрос - почему при транзакциях использут try-finally блоки?
# Conflicts: # server/src/main/java/com/example/vorona/server/db/DbBackend.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Воронина Веда