feat(node): add ability to merge mapping nodes (node.merge())#353
Draft
sitano wants to merge 1 commit into
Draft
feat(node): add ability to merge mapping nodes (node.merge())#353sitano wants to merge 1 commit into
sitano wants to merge 1 commit into
Conversation
Signed-off-by: Ivan Prisyazhnyy <john.koepi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A merge API for a
yaml.Nodethat can merge/replace mapping and sequence nodes depending on the configuration. The implementation currently consumessrcNode to avoid copy-pasting the whole tree hierarchy for the use cases where in the most cases I expect thesrcvalue will be dumped.Example
Notes
See test material for more details on the specifics of behavior.
The rules for processing nulls, implicit and explicit values are a bit complicated. Take a look at the tests.
There are a few cut corners but overall I think its more of a good than the opposite. e.g., it probably should not allow multi doc merge.