Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix COMPILATION issue in serving phrase #6

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

KepingYan
Copy link

@KepingYan KepingYan commented Mar 20, 2025

In serving phrase, Even if it hits the warmup shape, there is still COMPILATION warning.
image
After debugging, I found that the serving phrase will broadcast data in prepare_input(), but warmup doesn't do it. So add this op to avoid graph compilation in serving phase.

@yangulei yangulei requested a review from czhu15 March 20, 2025 06:30
Copy link
Owner

@yangulei yangulei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@czhu15 czhu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good finding! LGTM.

@yangulei yangulei merged commit fb6bf83 into yangulei:deepseek_r1_g2 Mar 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants