fix: allow sync return from wrapScriptExecution
and wrapNetworkRequest
hooks
#6795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Currently the typings of
wrapScriptExecution
andwrapNetworkRequest
hooks only allow to return aPromise
. There is no harm to allow a sync return, because the return will be anyways awaited at the runtime. A sync function can be awaited and it works as expected.How did you fix it?
Updated the typings to allow sync returns.
I marked this change as a patch, because this is only an issue with typings. Might be I missed something, but it looks like all works fine at the runtime.
Checklist