Added ClearlyDefined as User-Agent in default header #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashkohli88
force-pushed
the
yk/add-default-headers-centrally
branch
from
970f2e9 to
62b0626
Compare
yashkohli88
commented
Oct 14, 2024
providers/fetch/mavenBasedFetch.js
Outdated
| class MavenBasedFetch extends AbstractFetch { | ||
| constructor(providerMap, options) { | ||
| super(options) | ||
| this._providerMap = { ...providerMap } | ||
| this._handleRequestPromise = options.requestPromise || withDefaults(defaultHeaders) | ||
| this._handleRequestPromise = options.requestPromise || callFetch | ||
| this._handleRequestStream = options.requestStream || nodeRequest.defaults(defaultHeaders).get |
There was a problem hiding this comment.
This line should be rewritten as
this._handleRequestStream = options.requestStream || nodeRequest.defaults({ headers: defaultHeaders }).get in order to maintain the previous arrangement. Please let me know if this sounds good to you.
There was a problem hiding this comment.
Yes. Your way works! Another way can be
const { callFetch, defaultHeaders: headers } = require('../../lib/fetch')
...
const defaultHeaders = { headers }
Either one works.
qtomlinson
reviewed
Oct 15, 2024
providers/fetch/mavenBasedFetch.js
Outdated
| class MavenBasedFetch extends AbstractFetch { | ||
| constructor(providerMap, options) { | ||
| super(options) | ||
| this._providerMap = { ...providerMap } | ||
| this._handleRequestPromise = options.requestPromise || withDefaults(defaultHeaders) | ||
| this._handleRequestPromise = options.requestPromise || callFetch | ||
| this._handleRequestStream = options.requestStream || nodeRequest.defaults(defaultHeaders).get |
There was a problem hiding this comment.
Yes. Your way works! Another way can be
const { callFetch, defaultHeaders: headers } = require('../../lib/fetch')
...
const defaultHeaders = { headers }
Either one works.
| @@ -61,10 +61,7 @@ class PackagistFetch extends AbstractFetch { | |||
| if (!distUrl) return request.markSkip('Missing dist.url ') | |||
| return new Promise((resolve, reject) => { | |||
| const options = { | |||
| url: distUrl, | |||
| headers: { | |||
| 'User-Agent': 'clearlydefined.io crawler ([email protected])' | |||
There was a problem hiding this comment.
Here, we have to use imported defaultHeaders
qtomlinson
reviewed
Oct 15, 2024
test/unit/lib/fetchTests.js
Outdated
| }) | ||
|
|
||
| it('checks if the default header user-agent is present in packagist components', async () => { | ||
| const path = '/api.github.com/repos/php-fig/log/zipball/fe5ea303b0887d5caefd3d431c3e61ad47037001' |
yashkohli88
force-pushed
the
yk/add-default-headers-centrally
branch
from
64cf8bc to
17a52ef
Compare
Merge branch 'master' into yk/add-default-headers-centrally
…' into yk/add-default-headers-centrally
…deploy update workflow to operations/v3.2.0 which adds latest tag for Docker Hub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.