Support configured directory service principals - #161
Draft
jaykaycodes wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DIRECTORY_SERVICE_PRINCIPALScore configurationThis provides an explicit service-identity path for Slack-less and mixed-surface deployments related to #153 without treating every OIDC login as a directory member.
Verification
npm test(3717 tests, 3585 passed, 132 skipped, 0 failed)npm run typechecknpm run lint -- --quietNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.