fix(sandbox): install docker-cli and add container DNS fallback routing for local sandboxes - #240
Open
elf-mouse wants to merge 1 commit into
Open
Conversation
…ng for local sandboxes
This commit resolves docker socket permission issues and container-to-container networking for local sandboxes in containerized deployments:
1. `deploy/core/Dockerfile`:
- Install `docker-cli` package and allow root execution to access mounted `/var/run/docker.sock`.
2. `src/sandbox/local-sandbox.ts`:
- Fall back between `127.0.0.1`, `host.docker.internal`, and container hostname `http://${name}:8080` in `daemon()` to ensure reliable container-to-container execution across all environments.
iqbalbhatti49
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit resolves docker socket permission issues and container-to-container networking for local sandboxes in containerized deployments:
deploy/core/Dockerfile:docker-clipackage and allow root execution to access mounted/var/run/docker.sock.src/sandbox/local-sandbox.ts:127.0.0.1,host.docker.internal, and container hostnamehttp://${name}:8080indaemon()to ensure reliable container-to-container execution across all environments.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.