Add webpage translation font previews - #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Video subtitles already show a live typography preview, while webpage translations had no equivalent preview or configurable font. This makes the webpage result visible before translating and gives Chinese translations a readable default font.
Impact
Existing settings are normalized to the new LXGW WenKai Lite default. The selected font applies only to translated text inserted into webpages; source-page text and video subtitle settings remain unchanged.
Validation
pnpm -F @extension/content-script test(23 tests)pnpm lintpnpm type-checkpnpm builddist/options/fonts/Stack
Depends on #4. The PR base is
agent/elevenlabs-asr-fallbackso this diff contains only the font preview work.