Polish subtitle typography, fix live ASR bilingual display, persist settings - #6
Merged
Merged
Conversation
Font & subtitle design: - convert the bundled LXGW WenKai Lite from 13 MB TTF to 5 MB WOFF2 (lossless container change; OFL notice updated) - add WenKai as a subtitle style and make it the default, with a @font-face injected for the YouTube overlay - render the translated subtitle line at 0.9em of the platform caption size so CJK text no longer reads oversized, shrink the standalone ASR overlay base size, and clamp every overlay line to 2 lines Live ASR bilingual fix: - the translation line was blanked whenever a partial hypothesis was streaming, which in continuous speech meant translations never showed; keep showing the latest committed cue's translation (it lags one sentence) instead Settings persistence: - move translation settings, provider credentials, and the ElevenLabs key from chrome.storage.local to chrome.storage.sync so they survive uninstall/reinstall and follow the signed-in profile - one-time idempotent local→sync migration on background startup - pin the Chromium extension ID with a manifest key so unpacked/zip installs from different directories keep the same identity (Firefox already has a fixed gecko id); README privacy sections updated Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Font & subtitle design
THIRD_PARTY_NOTICES.mdand OFL references updated). Release zip drops from ~8.7 MB back to ~4 MB.@font-face.-webkit-line-clamp).Live ASR bilingual fix
Settings persistence
translation-settings,provider-credentials, andasr-credentialsmove fromchrome.storage.localtochrome.storage.sync— settings survive uninstall/reinstall and follow the signed-in browser profile. Translation cache stays local.key, pinning the extension ID (hioaccickilmocnacnbmfjbcihfgpmdj) so loading an unpacked/zip build from any directory keeps the same identity and storage. Firefox already pins viabrowser_specific_settings.gecko.id.Notes for existing installs
Validation
pnpm type-check,pnpm lint,pnpm -F @extension/content-script test(25 tests),pnpm build,pnpm build:firefoxkey+ WOFF2 web-accessible resource, Firefox manifest has nokey🤖 Generated with Claude Code