-
Notifications
You must be signed in to change notification settings - Fork 38
issue-4547: call IMixedBlockVisitor::Accept once for a merged block group instead of calling Accept for each block separately - prerequisite for subsequent performance improvement #4586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isitor::Accept once for merged block group instead of calling Accept for each block separately
SvartMetal
commented
Oct 30, 2025
Contributor
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 116e446.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 116e446.
|
SvartMetal
commented
Oct 31, 2025
e673
reviewed
Oct 31, 2025
SvartMetal
commented
Nov 9, 2025
Contributor
debnatkh
previously approved these changes
Dec 1, 2025
cloud/filestore/libs/storage/tablet/tablet_actor_flush_bytes.cpp
Outdated
Show resolved
Hide resolved
debnatkh
approved these changes
Dec 1, 2025
Contributor
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit df16de8.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit df16de8.
|
yegorskii
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4547
Currently it improves only mixed blocks benchmark, e2e read performance will be improved in subsequent PRs
Before:
After: