Skip to content

Package refactoring #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: package-refactor
Choose a base branch
from

Conversation

Willy-Chan
Copy link

Initial package refactoring for the new dashboard

  • implemented serve.js / experiment.js / index.js serving configuration
  • completed migration to google cloud buckets (deleted local assets)

TODO:

  • Implement i18next translation framework
  • Break up the experimentHelpers file into separate trials

KNOWN ISSUES:
image

  • The "progress bar" seems to be duplicating on my end periodically, with a functioning version on top and a duplicate below, the issue seems to come from this part in jsPsych.js:
  show_progress_bar: true,
  auto_update_progress_bar: true,
  message_progress_bar: `${i18next.t('progressBar')}`,
  on_finish: () => {
    document.body.style.cursor = "auto";
  },
});```

I have no clue as to how to fix this, as it seems to be an issue related to the jspsych module in the new package refactoring.

- [ ] As far as I can tell, the correct parameters are being logged, but I keep encountering the error below and I'm not sure what's causing it - is it something related to ANB or the new refactoring?
![image](https://github.com/yeatmanlab/roar-anb/assets/106504264/d1c71b34-c6a4-4011-9466-c7d8b4a97cb3)

- [ ] @miafuen We should make sure that all the correct parameters are being logged in the firebase

@Willy-Chan Willy-Chan requested review from Zio-4 and miafuen August 21, 2023 18:55
@Willy-Chan Willy-Chan requested a review from AnyaWMa October 2, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant