Bump ws from 8.16.0 to 8.17.1

[dependabot]

Bumps ws from 8.16.0 to 8.17.1.

Release notes

Sourced from ws's releases.

8.17.1

Bug fixes

• Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

1. Reduce the maximum allowed length of the request headers using the [--max-http-header-size=size][] and/or the [maxHeaderSize][] options so that no more headers than the server.maxHeadersCount limit can be sent.

... (truncated)

Commits

• 3c56601 [dist] 8.17.1
• e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
• 6a00029 [test] Increase code coverage
• ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
• b73b118 [dist] 8.17.0
• 29694a5 [test] Use the highWaterMark variable
• 934c9d6 [ci] Test on node 22
• 1817bac [ci] Do not test on node 21
• 96c9b3d [major] Flip the default value of allowSynchronousEvents (#2221)
• e5f32c7 [fix] Emit at most one event per event loop iteration (#2218)
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  You can disable automated security fix PRs for this repo from the Security Alerts page.

[yegor256]

@rultor please, try to merge

[rultor]

@rultor please, try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor please, try to merge

@dependabot[bot] @yegor256 Oops, I failed. You can see the full log here (spent 39min)

  357 |   rb_scan_args(argc, argv, "0*", &rest);
      |   ^~~~~~~~~~~~
xml_document.c: In function ‘create_entity’:
/usr/local/rvm/rubies/ruby-3.2.2/include/ruby-3.2.0/ruby/internal/scan_args.h:375:62: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
  375 |                      (rb_scan_args_verify(fmt, varc), vars), (char *)fmt, varc)
      |                                                              ^
/usr/local/rvm/rubies/ruby-3.2.2/include/ruby-3.2.0/ruby/internal/scan_args.h:498:9: note: in expansion of macro ‘rb_scan_args0’
  498 |         rb_scan_args0(                                        \
      |         ^~~~~~~~~~~~~
xml_document.c:436:3: note: in expansion of macro ‘rb_scan_args’
  436 |   rb_scan_args(argc, argv, "14", &name, &type, &external_id, &system_id,
      |   ^~~~~~~~~~~~
xml_document.c: At top level:
xml_document.c:495:14: error: conflicting types for ‘canonicalize’; have ‘VALUE(int,  VALUE *, VALUE)’ {aka ‘long unsigned int(int,  long unsigned int *, long unsigned int)’}
  495 | static VALUE canonicalize(int argc, VALUE* argv, VALUE self)
      |              ^~~~~~~~~~~~
In file included from /usr/include/features.h:486,
                 from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33,
                 from /usr/include/stdlib.h:26,
                 from ./nokogiri.h:4,
                 from ./xml_document.h:4,
                 from xml_document.c:1:
/usr/include/x86_64-linux-gnu/bits/mathcalls.h:370:1: note: previous declaration of ‘canonicalize’ with type ‘int(double *, const double *)’
  370 | __MATHDECL_1 (int, canonicalize,, (_Mdouble_ *__cx, const _Mdouble_ *__x));
      | ^~~~~~~~~~~~
In file included from /usr/local/rvm/rubies/ruby-3.2.2/include/ruby-3.2.0/ruby/ruby.h:47,
                 from /usr/local/rvm/rubies/ruby-3.2.2/include/ruby-3.2.0/ruby.h:38,
                 from ./nokogiri.h:33,
                 from ./xml_document.h:4,
                 from xml_document.c:1:
xml_document.c: In function ‘canonicalize’:
/usr/local/rvm/rubies/ruby-3.2.2/include/ruby-3.2.0/ruby/internal/scan_args.h:375:62: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
  375 |                      (rb_scan_args_verify(fmt, varc), vars), (char *)fmt, varc)
      |                                                              ^
/usr/local/rvm/rubies/ruby-3.2.2/include/ruby-3.2.0/ruby/internal/scan_args.h:498:9: note: in expansion of macro ‘rb_scan_args0’
  498 |         rb_scan_args0(                                        \
      |         ^~~~~~~~~~~~~
xml_document.c:511:3: note: in expansion of macro ‘rb_scan_args’
  511 |   rb_scan_args(argc, argv, "03", &mode, &incl_ns, &with_comments);
      |   ^~~~~~~~~~~~
xml_document.c: In function ‘init_xml_document’:
xml_document.c:554:6: warning: old-style function definition [-Wold-style-definition]
  554 | void init_xml_document()
      |      ^~~~~~~~~~~~~~~~~
xml_document.c: At top level:
cc1: note: unrecognized command-line option ‘-Wno-self-assign’ may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option ‘-Wno-parentheses-equality’ may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option ‘-Wno-constant-logical-operand’ may have been intended to silence earlier diagnostics
make: *** [Makefile:248: xml_document.o] Error 1

make failed, exit code 2

Gem files will remain installed in /usr/local/rvm/gems/ruby-3.2.2/gems/nokogiri-1.10.3 for inspection.
Results logged to /usr/local/rvm/gems/ruby-3.2.2/extensions/x86_64-linux/3.2.0/nokogiri-1.10.3/gem_make.out

A new release of RubyGems is available: 3.4.10 → 3.5.13!
Run `gem update --system 3.5.13` to update your installation.

container ec893a9379d7b650ec086ae25de7e5dc6f62f94a60860ac361eb24b8e2e4d7e9 is dead
Wed Jun 19 17:21:12 UTC 2024