feat(chats): replace book filter pills with a dropdown selector - #291
Merged
Conversation
Also render GFM markdown (tables, strikethrough, task lists) in AI replies via remark-gfm, and extract MessageBubble's inline markdown styles into a .markdown-body class in index.css. Closes #278 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Vocab words now always sort alphabetically; chats keep newest-first. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #278, plus two chat-rendering fixes folded in per review discussion.
Chats book filter dropdown (#278)
Selectprimitive gains an optional right-aligneddetailper option (backward-compatible with all existing consumers)scrollbar-noneon the list; the onlyoverflow-x-autoelement was the pill row, now gone)chats.allBooksRender GFM markdown in AI replies
AI replies containing tables rendered as literal pipe text because bare
react-markdownis CommonMark-only. Addedremark-gfmat all six<Markdown>call sites (MessageBubble, LookupPopover, ExplainPopover, VocabDetailModal), so tables, strikethrough, and task lists now render.Markdown style extraction
MessageBubble's inline markdown class wall (including inert
proseclasses —@tailwindcss/typographywas never installed) moved to a.markdown-bodyclass inindex.css, a 1:1 translation using the design tokens, extended with table styles (bordered cells, semibold headers, horizontal scroll for wide tables in the narrow AI panel).Closes #278
🤖 Generated with Claude Code