Add ColumnDefinitionParser class
#416
Open
+62
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #416 +/- ##
============================================
+ Coverage 98.62% 98.66% +0.03%
- Complexity 247 249 +2
============================================
Files 26 27 +1
Lines 800 823 +23
============================================
+ Hits 789 812 +23
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samdark
approved these changes
Nov 25, 2025
There was a problem hiding this comment.
Pull request overview
This PR adds a ColumnDefinitionParser class for MS SQL Server to parse column type definitions and their parameters. This is part of the broader refactoring in the yiisoft/db package (related to PR #1108).
Key Changes
- Implements
ColumnDefinitionParserclass extendingAbstractColumnDefinitionParserto handle MSSQL-specific type parameter parsing - Integrates the parser into
ColumnFactoryvia thecolumnDefinitionParser()method - Adds test coverage through
ColumnDefinitionParserTestextending common test base
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Column/ColumnDefinitionParser.php | New parser class implementing parseTypeParams() to handle size/precision/scale parsing for MSSQL column types |
| src/Column/ColumnFactory.php | Adds columnDefinitionParser() method to instantiate and return the new parser |
| tests/ColumnDefinitionParserTest.php | New test class extending common test base to verify parser functionality |
| CHANGELOG.md | Documents the addition of ColumnDefinitionParser class in version 2.0.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samdark
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to yiisoft/db#1108