Rename getLastInsertID() method in ConnectionInterface to getLastInsertId()

CHANGELOG.md

@@ -85,6 +85,7 @@
 - Enh #822: Refactor data readers (@Tigrov)
 - Enh #963: Make `Query::andHaving()` similar to `Query::andWhere()` (@Tigrov)
 - New #964: Add `QueryBuilderInterface::replacePlaceholders()` method (@Tigrov)
+- Enh #879: Rename `getLastInsertID()` method in `ConnectionInterface` to `getLastInsertId()` (@vjik)
 
 ## 1.3.0 March 21, 2024
 

src/Connection/ConnectionInterface.php

@@ -109,7 +109,7 @@ public function getDriverName(): string;
      *
      * @return string The row ID of the last row inserted, or the last value retrieved from the sequence object.
      */
-    public function getLastInsertID(?string $sequenceName = null): string;
+    public function getLastInsertId(?string $sequenceName = null): string;
 
     /**
      * Returns the query builder for the current DB connection.

src/Debug/ConnectionInterfaceProxy.php

@@ -69,9 +69,9 @@ public function getColumnFactory(): ColumnFactoryInterface
         return $this->connection->getColumnFactory();
     }
 
-    public function getLastInsertID(?string $sequenceName = null): string
+    public function getLastInsertId(?string $sequenceName = null): string
     {
-        return $this->connection->getLastInsertID($sequenceName);
+        return $this->connection->getLastInsertId($sequenceName);
     }
 
     public function getQueryBuilder(): QueryBuilderInterface

src/Driver/Pdo/AbstractPdoConnection.php

@@ -160,7 +160,7 @@ public function getPdo(): PDO|null
         return $this->pdo;
     }
 
-    public function getLastInsertID(?string $sequenceName = null): string
+    public function getLastInsertId(?string $sequenceName = null): string
     {
         if ($this->pdo !== null) {
             return $this->pdo->lastInsertID($sequenceName ?? null);

tests/Common/CommonCommandTest.php

@@ -1333,9 +1333,9 @@ public function testsInsertQueryAsColumnValue(): void
         $command->insert('{{order}}', ['customer_id' => 1, 'created_at' => $time, 'total' => 42])->execute();
 
         if ($db->getDriverName() === 'pgsql') {
-            $orderId = $db->getLastInsertID('public.order_id_seq');
+            $orderId = $db->getLastInsertId('public.order_id_seq');
         } else {
-            $orderId = $db->getLastInsertID();
+            $orderId = $db->getLastInsertId();
         }
 
         $columnValueQuery = (new Query($db))->select('{{created_at}}')->from('{{order}}')->where(['id' => $orderId]);
@@ -1630,9 +1630,9 @@ public function testNoTablenameReplacement(): void
         )->execute();
 
         if ($db->getDriverName() === 'pgsql') {
-            $customerId = $db->getLastInsertID('public.customer_id_seq');
+            $customerId = $db->getLastInsertId('public.customer_id_seq');
         } else {
-            $customerId = $db->getLastInsertID();
+            $customerId = $db->getLastInsertId();
         }
 
         $customer = $command->setSql(

tests/Common/CommonPdoConnectionTest.php

@@ -312,7 +312,7 @@ public function testTransactionRollbackTransactionOnLevel(): void
             'createCommand',
             'close',
             'getDriverName',
-            'getLastInsertID',
+            'getLastInsertId',
             'getQueryBuilder',
             'getQuoter',
             'getSchema',

tests/Db/Driver/PDO/PdoConnectionTest.php

@@ -36,7 +36,7 @@ public function testGetLastInsertID(): void
         $this->expectException(InvalidCallException::class);
         $this->expectExceptionMessage('DB Connection is not active.');
 
-        $db->getLastInsertID();
+        $db->getLastInsertId();
     }
 
     public function testQuoteValueString(): void

tests/Support/Stub/Schema.php

@@ -22,14 +22,6 @@ public function findUniqueIndexes(TableSchemaInterface $table): array
         throw new NotSupportedException(__METHOD__ . ' is not supported by this DBMS.');
     }
 
-    /**
-     * @throws NotSupportedException
-     */
-    public function getLastInsertID(?string $sequenceName = null): string
-    {
-        throw new NotSupportedException(__METHOD__ . ' is not supported by this DBMS.');
-    }
-
     protected function getCacheKey(string $name): array
     {
         return [];