Skip to content

Conversation

@rustamwin
Copy link
Member

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues comma-separated list of tickets # fixed by the PR, if any

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.64%. Comparing base (805f0d8) to head (dda40ba).
⚠️ Report is 60 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #192      +/-   ##
============================================
+ Coverage     97.61%   97.64%   +0.02%     
- Complexity      140      142       +2     
============================================
  Files             9        9              
  Lines           419      424       +5     
============================================
+ Hits            409      414       +5     
  Misses           10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a major release since it breaks BC.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UrlGeneratorInterface not depend from RouteCollection and may used:

  1. without RouteCollection,
  2. with one RouteCollection,
  3. with several RouteCollection.

We must keep URI prefix in UrlGeneratorInterface.

@rustamwin rustamwin closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants