-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed align parameters in basic-config as these were remnants from an… #51
Conversation
WalkthroughThis update corrects and clarifies a configuration file used in integration testing. The header in the alignment section is fixed from "alingment" to "alignment", and several parameters have been renamed for consistency (e.g., Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.tests/integration/config_basic/config.yaml (1)
91-92
: HLA Typing Section – Updated Mode CommentsThe inline comments for
MHC-I_mode
andMHC-II_mode
have been revised to indicate that a "custom" option is now supported. This clarification helps users understand that apart from existing values (e.g., "DNA, RNA" and "BOTH"), a custom configuration can be provided for specifying alleles manually if necessary.Please verify that the chosen default values ("DNA, RNA" for MHC-I and "BOTH" for MHC-II) align with the intended workflow and documentation.
### alignment | ||
align: | ||
minovlps: 10 | ||
chimsegmin: 20 | ||
chimoverhang: 10 | ||
chimmax: 50 | ||
chimmaxdrop: 30 | ||
chimSegmentMin: 20 | ||
chimScoreMin: 10 | ||
chimJunctionOverhangMin: 10 | ||
chimScoreDropMax: 20 | ||
chimScoreSeparation: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Alignment Section Parameter Renaming and Update
These changes update legacy parameter names in the alignment section:
chimSegmentMin
replaces the oldchimsegmin
.chimScoreMin
replaces the oldchimmax
.chimJunctionOverhangMin
replaces the oldchimoverhang
.chimScoreDropMax
replaces the oldchimmaxdrop
.- A new parameter
chimScoreSeparation
has been added with a value of 10.
This improves clarity and consistency with current naming conventions. Please ensure that any downstream modules or scripts referencing these parameters have also been updated accordingly.
… older version
Summary by CodeRabbit