Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jq #83

Closed
wants to merge 3 commits into from
Closed

Jq #83

wants to merge 3 commits into from

Conversation

lanej
Copy link
Contributor

@lanej lanej commented Mar 27, 2025

No description provided.

lanej added 3 commits March 2, 2025 16:40
- Introduced JqColors struct to handle JQ_COLORS parsing
- Updated ConfigContentStyle to support conversion from &str
- Modified Config default implementation to use JQ_COLORS
- Added tests for JqColors parsing and ConfigContentStyle conversion
- Updated ConfigFile to use ConfigContentStyle instead of ContentStyle
- Updated Config to use CrosstermContentStyle instead of ContentStyle
- Added JqColors parsing from environment variable in Config default
The CI workflow is now triggered on both push and pull_request events.
This ensures that tests are run for both direct pushes and pull
requests, improving the reliability of the codebase.
Removed the redundant map_err call in the write_default_config
condition within the main function.
@lanej lanej closed this Mar 27, 2025
@ynqa
Copy link
Owner

ynqa commented Mar 28, 2025

@lanej I made significant changes to the Config implementation, sorry about that :’(
Would you like to support JQ_COLOR as well?

Also, #77 was automatically closed after the merge. Please feel free to reopen it or here if needed.

@lanej
Copy link
Contributor Author

lanej commented Mar 28, 2025

@lanej I made significant changes to the Config implementation, sorry about that :’( Would you like to support JQ_COLOR as well?

Also, #77 was automatically closed after the merge. Please feel free to reopen it or here if needed.

No problem, I'll address the conflicts and repost.

For some reason Github didn't allow me to reopen #77 and change the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants