fix: Helm & Go linting

yonahd · Feb 16, 2025 · 1e92ed7 · 1e92ed7
1 parent 5483059
commit 1e92ed7
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/charts/kor/README.md b/charts/kor/README.md
@@ -22,7 +22,7 @@ A Kubernetes Helm Chart to discover orphaned resources using kor
 | cronJob.image.repository | string | `"yonahdissen/kor"` |  |
 | cronJob.image.tag | string | `"latest"` |  |
 | cronJob.name | string | `"kor"` |  |
-| cronJob.namespaced | string | `nil` |  |
+| cronJob.namespaced | string | `nil` | Set true/false to explicitly return namespaced/non-namespaced resources |
 | cronJob.restartPolicy | string | `"OnFailure"` |  |
 | cronJob.schedule | string | `"0 1 * * 1"` |  |
 | cronJob.slackAuthToken | string | `""` |  |
@@ -46,7 +46,7 @@ A Kubernetes Helm Chart to discover orphaned resources using kor
 | prometheusExporter.enabled | bool | `true` |  |
 | prometheusExporter.exporterInterval | string | `""` |  |
 | prometheusExporter.name | string | `"kor-exporter"` |  |
-| prometheusExporter.namespaced | string | `nil` |  |
+| prometheusExporter.namespaced | string | `nil` | Set true/false to explicitly return namespaced/non-namespaced resources |
 | prometheusExporter.service.port | int | `8080` |  |
 | prometheusExporter.service.type | string | `"ClusterIP"` |  |
 | prometheusExporter.serviceMonitor.enabled | bool | `true` |  |

diff --git a/charts/kor/values.yaml b/charts/kor/values.yaml
@@ -10,7 +10,8 @@ cronJob:
     - kor
   args:
     - all
-  namespaced: null # Set true/false to explicitly return namespaced/non-namespaced resources
+  # -- Set true/false to explicitly return namespaced/non-namespaced resources
+  namespaced: null
   slackWebhookUrl: ""
   slackChannel: ""
   slackAuthToken: ""
@@ -27,7 +28,8 @@ prometheusExporter:
     - kor
   args:
     - exporter
-  namespaced: null # Set true/false to explicitly return namespaced/non-namespaced resources
+  # -- Set true/false to explicitly return namespaced/non-namespaced resources
+  namespaced: null
   deployment:
     image:
       repository: yonahdissen/kor

diff --git a/cmd/kor/exporter.go b/cmd/kor/exporter.go
@@ -17,7 +17,6 @@ var exporterCmd = &cobra.Command{
 		apiExtClient := kor.GetAPIExtensionsClient(kubeconfig)
 		dynamicClient := kor.GetDynamicClient(kubeconfig)
 		kor.SetNamespacedFlagState(cmd.Flags().Changed("namespaced"))
-
 		kor.Exporter(filterOptions, clientset, apiExtClient, dynamicClient, "json", opts, resourceList)
 
 	},

diff --git a/pkg/kor/all.go b/pkg/kor/all.go
@@ -383,9 +383,8 @@ func GetUnusedAll(filterOpts *filters.Options, clientset kubernetes.Interface, a
 	if NamespacedFlagUsed {
 		if opts.Namespaced {
 			return GetUnusedAllNamespaced(filterOpts, clientset, outputFormat, opts)
-		} else {	
-			return GetUnusedAllNonNamespaced(filterOpts, clientset, apiExtClient, dynamicClient, outputFormat, opts)	
 		}
+		return GetUnusedAllNonNamespaced(filterOpts, clientset, apiExtClient, dynamicClient, outputFormat, opts)	
 	} 
 
 	unusedAllNamespaced, err := GetUnusedAllNamespaced(filterOpts, clientset, outputFormat, opts)