Feature: Custom Working Directory #1543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ties to `Scheme.Run`
… generating `XCScheme.LaunchAction`
…useCustomWorkingDirectory` properties
yonaskolb
reviewed
Jul 17, 2025
Sources/ProjectSpec/Scheme.swift
Outdated
| @@ -523,6 +530,8 @@ extension Scheme.Run: JSONObjectConvertible { | |||
| } | |||
| customLLDBInit = jsonDictionary.json(atKeyPath: "customLLDBInit") | |||
| macroExpansion = jsonDictionary.json(atKeyPath: "macroExpansion") | |||
| customWorkingDirectory = jsonDictionary.json(atKeyPath: "customWorkingDirectory") | |||
| useCustomWorkingDirectory = jsonDictionary.json(atKeyPath: "useCustomWorkingDirectory") ?? Scheme.Run.useCustomWorkingDirectoryDefault | |||
There was a problem hiding this comment.
We'll need to write these values in toJSONValue as well
yonaskolb
reviewed
Jul 17, 2025
Comment on lines
358
to
359
| customWorkingDirectory: scheme.run?.customWorkingDirectory, | ||
| useCustomWorkingDirectory: scheme.run?.useCustomWorkingDirectory ?? Scheme.Run.useCustomWorkingDirectoryDefault, |
There was a problem hiding this comment.
We could drop the useCustomWorkingDirectory property entirely and use a non nil value of customWorkingDirectory for this. What are your thoughts? Do you have need to set these separately?
There was a problem hiding this comment.
No, I don't have that need so I'll apply your suggestions 👍🏼
…he customWorkingDirectory is set to non nil
…rkingDirectory based on the value of Schema.Run.customWorkingDirectory
|
@yonaskolb I've applied your suggestions and added a check to make sure that |
…s no longer user defined.
yonaskolb
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted the ability to set the current working directory in the run action:
XcodeProj already supports this so I just added two new properties to
Scheme.Runso that they can be passed toXCScheme.LaunchActionduring the generation process.