Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add units to building size and axes distance in project setup dialog #71

Closed
wants to merge 2 commits into from

Conversation

pachi
Copy link

@pachi pachi commented Dec 7, 2020

As explained in #70 , building size and axes distance use by default mm, if no explicit unit is used, this is a bit surprising if you have setup other units as preferred (e.g. meters).
As it's possible to use explicit units, maybe this is not the right fix for the issue.

Rafael Villar Burke added 2 commits December 7, 2020 18:48
Latitude and latitud should be provided in the [-90, +90] and [-180, +180] ranges.
Also, minimum value property must be set to be able to use negative numbers.
@pachi pachi changed the title Fix/sizeunits Add units to building size and axes distance in project setup dialog Dec 7, 2020
@yorikvanhavre
Copy link
Owner

It is a general rule of FreeCAD that if you don't specify a unit, millimeters are used. This is subject to discussion, but the main rationale behind this is that a stored expression (for ex. "20m+12"), should always return the same result on every system, no matter what the user's unit is in.
Adding [mm] the way you propose is misguiding I think, because it may induce users to think you cannot use any other unit. Rather, I'd argue the correct way would be to find ways to make all users aware that if you don't specify any unit, mm are always used

@pachi
Copy link
Author

pachi commented Dec 9, 2020

Yes, indeed. I'm sure this is not the right fix.
I'm still not familiar with FreeCAD source and haven't investigated it enough, but IIRC many entries do have the used units as suffix. That would be the best option, adding units to the default text.

@pachi pachi closed this Dec 20, 2020
@pachi pachi deleted the fix/sizeunits branch December 20, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants