Add workflow to publish container - #29
Merged
Merged
Conversation
Owner
|
Nice follow-up — this is exactly what we discussed. Multi-platform builds, GHA caching, build-only on PRs, push on tags. Clean. Two things before merge:
Optional nit: add I'll set up the quay.io repo and add the secrets on my end. |
Contributor
Author
|
Other feedback addressed, newline at end of file, and a name has been added to the workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub workflow to publish container images when a git tag is pushed (can be triggered via GitHub releases as well).
There are also non-pushing builds that occur on PRs and on pushes to main. This is to ensure that the Containerfile never becomes stale.
Required before merge
QUAY_USERNAMEandQUAY_PASSWORD