feat: adopt X-Client-Info attribution header and bump SDK floor to 3.1.2 - #15
Merged
Merged
Conversation
Replace the post-construction `user_agent` mutation with `app_name` / `app_version` constructor kwargs so the SDK's `X-Client-Info` header emits `client=youdotcom-temporal/<version>` on every outbound request. The SDK's own `user-agent` stays as `youdotcom-python-sdk/<v>`. - Bump `youdotcom>=3.0.0,<4` to `>=3.1.2,<4` - Drop `_USER_AGENT` constant and `sdk_configuration.user_agent` mutation - Update `tests/test_client.py` to assert the new constructor kwargs - Regenerate `uv.lock` Closes DX-784 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
tyler5673
marked this pull request as ready for review
August 21, 2026 19:21
tyler5673
added a commit
that referenced
this pull request
Aug 21, 2026
Rebased onto main with PR #15 (SDK 3.1.2 + attribution header) and PR #16 (extraction parameter) merged. Squashes the nexus spike into one clean commit. - YouDotComService exposes all six Activities as async Nexus Operations - contract.py holds the Nexus contract with SDK response models - workflows.py ships six thin backing Workflows with per-Activity ceilings - Idempotency key support for deduplication of Nexus StartOperation retries - Unit tests covering contract, handler, and sandbox registration - Integration tests for live Nexus round-trip (gated behind -m integration) Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
tyler5673
added a commit
that referenced
this pull request
Aug 21, 2026
Rebased onto main with PR #15 (SDK 3.1.2 + attribution header) and PR #16 (extraction parameter) merged. Squashes the nexus spike into one clean commit. - YouDotComService exposes all six Activities as async Nexus Operations - contract.py holds the Nexus contract with SDK response models - workflows.py ships six thin backing Workflows with per-Activity ceilings - Idempotency key support for deduplication of Nexus StartOperation retries - Unit tests covering contract, handler, and sandbox registration - Integration tests for live Nexus round-trip (gated behind -m integration) Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
Bumps the Python SDK floor from
>=3.0.0,<4to>=3.1.2,<4and adopts the SDK's newX-Client-Infoattribution header (shipped inyoudotcom3.1.2).The plugin now passes
app_name="youdotcom-temporal"andapp_version=<package version>to theYou(...)constructor instead of mutatingclient.sdk_configuration.user_agentpost-construction. Each outbound request carries:user-agent: youdotcom-python-sdk/3.1.2 httpx/<v>(SDK identity)X-Client-Info: sdk; client=youdotcom-temporal/<version>; ua=python/<v> httpx/<v>(plugin identity)The
_USER_AGENTconstant and thesdk_configuration.user_agentmutation are removed.Changes
pyproject.tomlyoudotcom>=3.0.0,<4->>=3.1.2,<4src/youdotcom_temporal/_client.pyapp_name/app_versiontoYou(...); drop_USER_AGENTanduser_agentmutationtests/test_client.pyapp_name/app_versionin constructor kwargs; drop_USER_AGENTassertionsCHANGELOG.mduv.lockVerification
uv run ruff check-- passeduv run mypy src-- passed (0 issues)uv run pytest-- 77 passed, 8 deselected (integration)Related
livecrawltoextractionmigration (separate PR branched off this one)Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>