fix: resolve SparseDistribution crash on zero/NaN probability mass#83
Open
Jonathangadeaharder wants to merge 1 commit into
Open
fix: resolve SparseDistribution crash on zero/NaN probability mass#83Jonathangadeaharder wants to merge 1 commit into
Jonathangadeaharder wants to merge 1 commit into
Conversation
4c2dc4f to
e4cf880
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #82
Changes
SparseDistributionConstructor: MadeSparseDistribution.__post_init__fall back to a valid one-hot distribution on the first available token (greedy choice) if the sum of the probabilities is not finite or<= 0, rather than raising a crash-inducingValueError.residual_distribution: Addednot np.isfinite(total)checks to the fallback paths inresidual_distribution(sparse, dense, and non-sparse branches) to preventNaNvalues from bypassing target fallbacks.tests/test_sampling.pyverifying fallback recovery on zero/NaN probability mass, as well as a mock test forresidual_distributionNaN robustness.All tests pass successfully.