Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IS_EVERGREEN_ADDRESS macro #4823

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Fix IS_EVERGREEN_ADDRESS macro #4823

merged 1 commit into from
Feb 14, 2025

Conversation

astolcenburg
Copy link

@astolcenburg astolcenburg commented Feb 3, 2025 •
edited by kaidokert
Loading

Fixes IS_EVERGREEN_ADDRESS macro for values >= 0x80000000 on 32-bit systems

b/299486087

@kaidokert kaidokert changed the title Fix IS_EVERGREEN_ADDRESS macro for values >= 0x80000000 on 32-bit sys… Fix IS_EVERGREEN_ADDRESS macro Feb 9, 2025
kaidokert
kaidokert approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - if this compiles and tests pass, lgtm

@hlwarriner hlwarriner added the runtest Trigger presubmit workflows. label Feb 12, 2025
hlwarriner
hlwarriner approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@hlwarriner hlwarriner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this fix!

@kaidokert kaidokert merged commit 1c613ae into youtube:25.lts.1+ Feb 14, 2025
1041 of 1050 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidokert kaidokert kaidokert approved these changes

@hlwarriner hlwarriner hlwarriner approved these changes

Assignees
No one assigned
Labels
on_device outside collaborator runtest Trigger presubmit workflows.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astolcenburg @kaidokert @hlwarriner