Disable IPv6 functionality in Cobalt on platforms without IPv6 support #4856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b/394777605 On platforms where IPv6 is not supported, performing the IPv6 reachability check caused a DCHECK failure in development mode. This change introduces a macro check (SB_HAS(IPV6)) to conditionally execute the DoIPv6Reachability() function only when IPv6 support is available. If IPv6 is not supported, the state transitions directly to STATE_GET_PARAMETERS, bypassing the unnecessary check. This prevents erroneous DCHECK failures on platforms without IPv6. Signed-off-by: MSoliankoLuxoft <[email protected]>
amurovanyi
approved these changes
Feb 6, 2025
|
@kaidokert, please review this PR or assign someone who is aware about IPv6 support in Cobalt |
kaidokert
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/394777605
On platforms where IPv6 is not supported, performing the IPv6 reachability check caused a DCHECK failure in development mode.
This change introduces a macro check (SB_HAS(IPV6)) to conditionally execute the DoIPv6Reachability() function only when IPv6 support is available.
If IPv6 is not supported, the state transitions directly to STATE_GET_PARAMETERS, bypassing the unnecessary check.
This prevents erroneous DCHECK failures on platforms without IPv6.