Add RenderProcessHostObserver::InProcessRendererExiting #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidokert
reviewed
Feb 12, 2025
andrewsavage1
approved these changes
Feb 12, 2025
This new notification is useful for worker code that needs to observe the render process exiting, which doesn't work in --single-process mode. Used in this CL to fix an issue where 2 RenderProcessHostObservers were watching for the RenderProcessHostDestroyed() notification to clean up nodes on the performance manager graph, but one of the observer needed to be notified first, which depended on the somewhat random order of the observers in the observer list. This change is backported from m118+. (cherry picked from commit 3426bf6e8f2eb618d09608b4379ee73f2c4c31a9) Bug: 391938746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4780551
borongc
force-pushed
the
render_processor_host
branch
from
206cebc to
3e75d23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new notification is useful for worker code that needs to observe the render process exiting, which doesn't work in --single-process mode.
Used in this CL to fix an issue where 2 RenderProcessHostObservers were watching for the RenderProcessHostDestroyed() notification to clean up nodes on the performance manager graph, but one of the observer needed to be notified first, which depended on the somewhat random order of the observers in the observer list.
This change is backported from m118+.
(cherry picked from commit 3426bf6e8f2eb618d09608b4379ee73f2c4c31a9)
b/391938746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4780551