-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DeepLinkManager, move startDeepLink out of StarboardBridge #5002
Add DeepLinkManager, move startDeepLink out of StarboardBridge #5002
Conversation
0d64fc2
to
20eb461
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments off the cuff. DeepLinkManager
needs a unit test (which can be trivial, yes).
This reverts commit f8f2829.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, some comments.
The JS getInitialDeepLink()
behaviour is surprising (clear upon read). A comment in the IDL would be the minimum required, but perhaps we could rename the API? (Later, perhaps?)
cobalt/android/apk/app/src/main/java/dev/cobalt/coat/StarboardBridge.java
Outdated
Show resolved
Hide resolved
cobalt/android/apk/app/src/main/java/dev/cobalt/coat/StarboardBridge.java
Outdated
Show resolved
Hide resolved
...nk/web_tests/wpt_internal/cobalt/h5vcc-runtime/h5vcc-runtime-getInitialDeepLink.https.any.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few comment nits! Thanks for the patience during the review.
To be reviewed after #4993 is merged.
Tested on devtools. https://screenshot.googleplex.com/8DZB3z5ykQu3aTk
b/374147993