Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeepLinkManager, move startDeepLink out of StarboardBridge #5002

Merged
merged 21 commits into from
Mar 6, 2025

Conversation

zhongqiliang
Copy link
Contributor

@zhongqiliang zhongqiliang commented Mar 3, 2025

To be reviewed after #4993 is merged.

  1. Relocate startDeepLink from StarboardBridge.
  2. Create a DeepLinkManager singleton to manage startDeepLink.
  3. H5vccRuntimeImpl::GetInitialDeepLink() implementation in the Mojom service will now reset the deeplink to its default value after being called.

Tested on devtools. https://screenshot.googleplex.com/8DZB3z5ykQu3aTk

b/374147993

@zhongqiliang zhongqiliang requested a review from a team as a code owner March 3, 2025 19:53
@zhongqiliang zhongqiliang requested a review from briantting March 3, 2025 19:53
@zhongqiliang zhongqiliang requested review from yell0wd0g, kaidokert, hlwarriner and andrewsavage1 and removed request for briantting March 3, 2025 20:06
@zhongqiliang zhongqiliang force-pushed the add_deeplink_manager_2 branch from 0d64fc2 to 20eb461 Compare March 3, 2025 22:45
Copy link
Contributor

@yell0wd0g yell0wd0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments off the cuff. DeepLinkManager needs a unit test (which can be trivial, yes).

yell0wd0g

This comment was marked as duplicate.

@zhongqiliang zhongqiliang requested a review from yell0wd0g March 5, 2025 00:25
Copy link
Contributor

@yell0wd0g yell0wd0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some comments.

The JS getInitialDeepLink() behaviour is surprising (clear upon read). A comment in the IDL would be the minimum required, but perhaps we could rename the API? (Later, perhaps?)

@zhongqiliang zhongqiliang requested a review from yell0wd0g March 5, 2025 04:57
Copy link
Contributor

@yell0wd0g yell0wd0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few comment nits! Thanks for the patience during the review.

@zhongqiliang zhongqiliang enabled auto-merge March 6, 2025 02:01
@zhongqiliang zhongqiliang merged commit acdc028 into youtube:main Mar 6, 2025
136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants