Upload Android symbol file independently #5070
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unstripped Android symbol file from package and add it to its own directory when uploading to GCS. b/401246294
kaidokert
reviewed
Mar 13, 2025
| @@ -247,6 +247,11 @@ run_package_release_pipeline () { | |||
| local package_platform="linux" | |||
| if [[ "${PLATFORM}" =~ "android" ]]; then | |||
| package_platform="android" | |||
|
|
|||
There was a problem hiding this comment.
I'm fine if you want to get this landed to solve an immediate problem. But isn't a more sustainable way to do this simply to define another archive_datas entry in the file above ?
E.g. in here https://github.com/youtube/cobalt/blob/main/infra/archive_config/linux-archive-rel.json
There are simply multiple entries defined by separate gcs_path keys, we can simply maybe have "gcs_path" : "symbol-file.zip" key and move the unstripped file there ?
kaidokert
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unstripped Android symbol file from package and add it to its own directory when uploading to GCS.
b/401246294