Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable //media/starboard:unit_tests #5206

Merged
merged 3 commits into from
Apr 1, 2025
Merged

Conversation

kjyoun
Copy link
Contributor

@kjyoun kjyoun commented Mar 26, 2025

Enable //media/starboard:unit_tests

b/379936173
b/379934533
b/380335617

@kjyoun kjyoun requested a review from a team as a code owner March 26, 2025 20:57
@kjyoun kjyoun changed the title Enable unit tests Enable //media/starboard:unit_tests Mar 26, 2025
@xiaomings xiaomings requested a review from jasonzhangxx March 28, 2025 22:33
Copy link
Contributor

@jasonzhangxx jasonzhangxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cl itself looks good to me. Can we run and pass all tests?

@kjyoun
Copy link
Contributor Author

kjyoun commented Mar 28, 2025

Yes, all added tests are passed

https://paste.googleplex.com/6165907427295232

@kjyoun
Copy link
Contributor Author

kjyoun commented Mar 31, 2025

And these starboard_unittest will run during PR check once #5239 is merged

@kjyoun kjyoun force-pushed the enable_unit_tests branch from deba596 to 008f8a3 Compare April 1, 2025 20:13
@kjyoun kjyoun enabled auto-merge (squash) April 1, 2025 20:13
@kjyoun kjyoun merged commit e7123e5 into youtube:main Apr 1, 2025
232 of 235 checks passed
@kjyoun kjyoun deleted the enable_unit_tests branch April 1, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants