Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude vulkan headers from ui/gl. #5212

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Exclude vulkan headers from ui/gl. #5212

merged 1 commit into from
Mar 27, 2025

Conversation

y4vor
Copy link
Contributor

@y4vor y4vor commented Mar 27, 2025

b/406613669

@y4vor y4vor requested a review from a team as a code owner March 27, 2025 01:53
yell0wd0g
yell0wd0g approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@yell0wd0g yell0wd0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excluding makes sense, but perhaps we could use the vulkan buildflag?

@y4vor y4vor merged commit 87f8891 into youtube:main Mar 27, 2025
152 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yell0wd0g yell0wd0g yell0wd0g approved these changes

@kaidokert kaidokert Awaiting requested review from kaidokert kaidokert is a code owner automatically assigned from youtube/cobalt-3p-repository-owners

@andrewsavage1 andrewsavage1 Awaiting requested review from andrewsavage1

@sherryzy sherryzy Awaiting requested review from sherryzy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y4vor @yell0wd0g