Cherry pick PR #5113: [media] Move StarboardRenderer to MojoRenderer #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move StarboardRenderer to Gpu thread, and each of StarboardRenderer is ran on PooledSingleThreadTaskRunner. This allows Starboard to access `Chrome_InProcGpuThread` for graphical tasks. This PR adds a `CreateStarboardRenderer()` to the InterfaceFactory mojom with the purpose of running StarboardRenderer on Gpu thread; this forced an implementation in a number of places, namely MediaInterfaceFactory, MediaInterfaceProxy and FramelessMediaInterfaceProxy. b/394368542 b/378740140 b/405401569 (cherry picked from commit df40583)
cobalt-github-releaser-bot
requested review from
kaidokert
and removed request for
a team
borongc
approved these changes
Mar 27, 2025
Datadog ReportBranch report: ✅ 0 Failed, 29714 Passed, 2925 Skipped, 1m 24.16s Total Time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #5113
Move StarboardRenderer to Gpu thread, and each of StarboardRenderer is ran on PooledSingleThreadTaskRunner. This allows Starboard to access
Chrome_InProcGpuThreadfor graphical tasks.This PR adds a
CreateStarboardRenderer()to the InterfaceFactory mojom with the purpose of running StarboardRenderer on Gpu thread; this forced an implementation in a number of places, namely MediaInterfaceFactory, MediaInterfaceProxy and FramelessMediaInterfaceProxy.b/394368542
b/378740140
b/405401569