Laravel Analyzer #8
Conversation
The Laravel framework adopts the PSR-2 coding style in version 5.1. Laravel apps *should* adopt this coding style as well. Read the [PSR-2 coding style guide][1] for more details and check out [PHPCS][2] to use as a code formatting tool. [1]: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md [2]: https://github.com/squizlabs/PHP_CodeSniffer
|
⚠ The following files reference Laravel facades through the global namespace. For example, you're referencing While global references are allowed through aliases, you should import the facade explicitly. This can improve clarity not only for developers, but static analysis used by your IDE.
|
|
⚠ The following controllers contain actions outside of the 7 resource actions (
|
|
⚠ Shift found inline validation in the following controllers. Unless you require this level of control, you should use a Form Request to encapsulate this validation logic and keep your controller clean.
|
|
⚠ Shift found opportunities to use the built-in Blade directives like
|
|
❌ Shift could not run |
|
⚠ Shift found the following config files differ from the defaults. While you are welcome to customize your configuration, you should leverage ENV variables rather than hardcode values. If you find you're adding a lot of configuration options, consider creating a domain specific config file, such as
|
|
ℹ If you have manually upgraded your app from previous versions of Laravel, you should run the Laravel Linter to ensure your app is fully upgraded to the latest version of Laravel. |
2 participants
This pull request includes changes and recommendations for crafting your application "The Laravel Way". Feel free to commit any additional changes to the
shift-11210branch.Before merging, you should:
shift-11210branchIf you want help with your upgrade, check out the Shift Human Services or join the Shifty Coders Slack room to get answers to all your Laravel questions.