Retry a suite that recorded no test case, not one that left no directory

[yschimke]

Follow-up to #33, whose retry never fired on the failure it was written for.

The defect

The retry asked whether the results directory was absent. A run whose APK install never happened still leaves that directory behind — empty. So on the merge commit of #33 the Android public suite did this:

'package install-create ...' returns error 'Unknown failure: cmd: Can't find service: package'
Starting 0 tests on emulator-5554
PublicEncryptedClientHelloTest failed; recorded, not fatal.

Zero tests, no retry attempted, non-fatal path taken, job green. Exactly the outcome the retry existed to prevent, and indistinguishable on the status page from a suite that had nothing to say.

The fix

Ask about test cases rather than about the directory. Checked against all four states:

results state	retries?
no directory	yes
empty directory	yes
XML with zero test cases (the observed failure)	yes
XML with real results	no

Only the last declines, which is the intent.

Also: one wait, not two

wait_for_package_service is removed. #31 landed a real readiness gate a few commits after #33, and it is strictly stronger on every axis — it waits on the settings provider and external storage as well as the package service, proves the path with a live call, and fails the run instead of shrugging when the device never arrives. Two waits where the weaker one runs second is just a claim that the first didn't work. #31's gate is what should prevent zero-test runs; the retry is the backstop for when it doesn't.

What this does not do

It does not say whether ECH works on API 37. No run has yet executed those six public cases — the first two never installed, and the third failed on the PublicSuffixDatabase.list asset that #33 fixed. This change only ensures that a run which doesn't execute them stops looking like one that did.

---

Generated by Claude Code