Unblock the Go pin and the Testcontainers 2 bump - #59
Merged
Conversation
setup-go pinned 1.24.13 and sets GOTOOLCHAIN=local, so a go.mod directive above that fails the vet step outright rather than fetching a toolchain (#43: "go.mod requires go >= 1.26.6 (running go 1.24.13)"). The module already declares its floor, and the Dockerfile builds on golang:1.26 — the workflow was the only place holding an independent number. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GJPgEqTgwRY7dd8diBX7Sj
2.0 prefixes every module with testcontainers- and relocates the container classes out of org.testcontainers.containers, so bumping the shared version ref alone leaves junit-jupiter and mockserver pointing at coordinates that don't exist at 2.x — which is what #52 hit. Rename both in the catalogue and follow MockServerContainer to org.testcontainers.mockserver. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GJPgEqTgwRY7dd8diBX7Sj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixes behind the two red renovate PRs, #43 and #52. Neither was a bad update — both needed a change renovate can't make itself.
#43 — the Go pin
setup-gopinned1.24.13in the workflow and setsGOTOOLCHAIN=local, so raising thegodirective failed the vet step outright rather than fetching a toolchain:The workflow now reads
go-version-file: test-server/go.mod. The module already declares its own floor andtest-server/Dockerfilealready builds ongolang:1.26, so the workflow was the last place holding a separate number. This leaves #43's one-linego.modchange to merge on its own — rebase it and it should go green. Worth a thought separately on whether the directive wants to be a full patch version at all, orgo 1.26plus atoolchainline.#52 — Testcontainers 2
Testcontainers 2.0 prefixed every module with
testcontainers-and moved the container classes out oforg.testcontainers.containers. Renovate bumped the sharedtestcontainersversion ref, which also drives themockserverandjunit-jupiterentries — coordinates that don't exist at 2.x:So this carries the 2.0.5 bump plus the migration: both modules renamed in the catalogue, and
MockServerContainerfollowed toorg.testcontainers.mockserverin the four suites that use it. That makes #52 redundant — it can be closed once this lands.Verification
:containers:compileTestKotlinpasses against 2.0.5 with no deprecation warnings left. The container suites themselves need a Docker daemon, which this environment doesn't have, so their first real run is CI here.🤖 Generated with Claude Code
https://claude.ai/code/session_01GJPgEqTgwRY7dd8diBX7Sj
Generated by Claude Code