Avoid redirect when checking HTTPS address hints - #77
Merged
Conversation
yschimke
marked this pull request as ready for review
August 15, 2026 21:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/cdn-cgi/traceendpoint when checking HTTPS-record address hints/robots.txtis unsafe with the test's pinned DNS implementationRoot cause
cloudflare.com/robots.txtredirects towww.cloudflare.com/robots.txt. The test DNS implementation deliberately returns the selectedcloudflare.comaddress hint for every lookup, so OkHttp reused that address for the redirected hostname. Cloudflare rejected the mismatchedwww.cloudflare.comrequest with HTTP 403 (error code: 1034) even though the original address hint was reachable.Impact
The reachability finding no longer reports a false failure caused by a cross-host redirect. It still requires a successful HTTP 200 response through the selected HTTPS-record address hint.
Validation
./gradlew :network:networkTest --tests 'okhttp.testbed.network.HttpsRecordTest.addressHintsAreReachable' -PokhttpVersion=5.5.0-SNAPSHOT --rerun-tasks