Skip to content

Test Android ECH on APIs 21, 30, 35, and 37 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yschimke merged 1 commit into from
Aug 15, 2026
Merged

Test Android ECH on APIs 21, 30, 35, and 37 #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/android-ech.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,18 @@ jobs:
# TLS 1.3 only — but the run still installs the instrumentation APK and calls
# `OkHttp.initialize`, so a published artifact that stopped loading on the oldest
# supported Android is caught here rather than by whoever still ships to it.
# 29 the first level with TLS 1.3, and so the first that can reach the fixture at all.
# What it asserts is the fallback: a config list OkHttp cannot use must produce an
# ordinary handshake to the real name, not a failed call.
# 34 the same, on the release most devices in the field are on.
# 30 an older level with TLS 1.3. What it asserts is the fallback: a config list
# OkHttp cannot use must produce an ordinary handshake to the real name, not a
# failed call.
# 35 the same, on a recent release used by devices in the field.
# 37 where `android.net.ssl.EchConfigList` exists and ECH is actually performed.
#
# Play Store images exist only for the newest level, so the older rows take the plain
# `google_apis` image — and API 21, which predates those, the `default` one.
matrix: >-
${{ fromJSON(
(github.event_name == 'schedule' || github.event_name == 'workflow_dispatch')
&& '{"include":[{"apiLevel":"21","target":"default","arch":"x86_64"},{"apiLevel":"29","target":"google_apis","arch":"x86_64"},{"apiLevel":"34","target":"google_apis","arch":"x86_64"},{"apiLevel":"37.0","target":"google_apis_playstore_ps16k","arch":"x86_64"}]}'
&& '{"include":[{"apiLevel":"21","target":"default","arch":"x86_64"},{"apiLevel":"30","target":"google_apis","arch":"x86_64"},{"apiLevel":"35","target":"google_apis","arch":"x86_64"},{"apiLevel":"37.0","target":"google_apis_playstore_ps16k","arch":"x86_64"}]}'
|| '{"include":[{"apiLevel":"37.0","target":"google_apis_playstore_ps16k","arch":"x86_64"}]}'
) }}

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ once. They run on the schedule, and on demand:
| `containers (…, JDK 8 · 11 · 17 · 21 · 25)` | the snapshot on 17 and up, the pinned release on all five | schedule and manual runs only |
| `network / compile` | the `okhttp` version in `libs.versions.toml` | push and pull request |
| `network (…, JDK 8 · 11 · 17 · 21 · 25)` | the snapshot on 17 and up, the pinned release on all five | schedule and manual runs only |
| `android-ech (…, API 21 · 29 · 34 · 37)` | the snapshot | API 37 on every event, the rest on schedule and manual runs only |
| `android-ech (…, API 21 · 30 · 35 · 37)` | the snapshot | API 37 on every event, the rest on schedule and manual runs only |

What keeps the network module honest between scheduled runs is `network / compile`, which
runs on every push and pull request touching `network/**` and calls nobody: it compiles the
Expand Down