Classify pre-JDK 24 Loom pinning as expected - #84
Merged
Conversation
yschimke
marked this pull request as ready for review
August 15, 2026 21:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BasicLoomTest.testHttpsRequestfailures as expected on JDK 21–23Why
On JDK 21–23,
Http2Connection.newStreamholds intrinsic monitors whileHttp2Writer.flushperforms a potentially blocking write. A virtual thread that blocks there pins its carrier. JEP 491 changes this behavior starting in JDK 24, so the existing status collector should distinguish the predicted older-JDK failure from a regression on newer JDKs.This keeps the original assertion intact and preserves the JUnit evidence while presenting the known pre-JDK-24 result as expected rather than as an unpredicted finding.
Verification
node --test site/assets/finding-groups.test.js./gradlew containers:compileTestKotlingit diff --check