Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations to from_dict, from_tuple and from_msgpack #325

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

yukinarit
Copy link
Owner

No description provided.

@yukinarit yukinarit added the bug Bug report or fix label Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (f0b076b) 91.07% compared to head (e4cc087) 91.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #325   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files          12       12           
  Lines        1771     1771           
  Branches      376      376           
=======================================
  Hits         1613     1613           
  Misses        110      110           
  Partials       48       48           
Impacted Files Coverage Δ
serde/msgpack.py 100.00% <ø> (ø)
serde/de.py 96.44% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yukinarit yukinarit linked an issue Mar 3, 2023 that may be closed by this pull request
@yukinarit yukinarit marked this pull request as ready for review March 3, 2023 12:49
@yukinarit yukinarit merged commit 4d66e94 into main Mar 3, 2023
@yukinarit yukinarit deleted the fix-typing branch March 3, 2023 12:49
github-actions bot pushed a commit that referenced this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report or fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_dict causes "is incompatible with" type error
1 participant