Fix for issue 27 support for log, info,error, warn and verbose methods of context objects #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2019 18:16
…for not to test on log method
|
Why have you closed this PR? |
|
Actually travis job was failed due to no space after json key name and
colon.
So I closed this PR #28
I didn't saw that tab spacing is affected with my commit, apologies.
Iwill fix that in future.
…On Wed, Feb 13, 2019, 7:27 PM Yves M. ***@***.*** wrote:
Why has you closed this?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AO5z-P73zYHNalj_C9jKYj1rTtKOvk_0ks5vNBnegaJpZM4a5VnP>
.
|
|
You don't have to re-open a PR to fix a commit.. you only have to re-commit in the branch.. |
|
Yup, I missed it.
Apologies.
…On Wed, Feb 13, 2019, 8:58 PM Yves M. ***@***.*** wrote:
You don't have to re-open a PR to fix a commit.. you only have to
re-commit in the branch..
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AO5z-DHVL8vCvY6KyTx9iEg757YQlGj2ks5vNC8WgaJpZM4a5VnP>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27 Fix for issue 27 support for log, info,error, warn and verbose methods of context objects