Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update general-guidelines.adoc #627

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Update general-guidelines.adoc #627

merged 2 commits into from
Feb 10, 2021

Conversation

a-akimov
Copy link
Contributor

Fixed typo and spelling of OpenAPI

Fixed typo and spelling of OpenAPI
@tfrauenstein
Copy link
Member

👍

1 similar comment
@tkrop
Copy link
Member

tkrop commented Jan 19, 2021

👍

@tkrop
Copy link
Member

tkrop commented Jan 19, 2021

Thanks, seems as if only two locations now are left.

@tkrop
Copy link
Member

tkrop commented Jan 20, 2021

@a-akimov while we would like to merge this, we can't since the build failed because of a temporary failure. Can you re-trigger it to make it successful? I unfortunately can't.

@a-akimov
Copy link
Contributor Author

@a-akimov while we would like to merge this, we can't since the build failed because of a temporary failure. Can you re-trigger it to make it successful? I unfortunately can't.

@tkrop thank you for reviewing. I would love to re-trigger, but not sure how exactly to do this. Or you mean to make another commit and pull request?

@tkrop
Copy link
Member

tkrop commented Jan 26, 2021

should also work.

@tkrop
Copy link
Member

tkrop commented Feb 5, 2021

the simplest way is to do git commit --amend and git push --force on the branch get this rebuild.

@ePaul
Copy link
Member

ePaul commented Feb 8, 2021

I've retriggered the build in Travis CI's UI.

@ePaul
Copy link
Member

ePaul commented Feb 8, 2021

👍

1 similar comment
@tkrop
Copy link
Member

tkrop commented Feb 10, 2021

👍

@tkrop tkrop merged commit 040ae6a into zalando:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants