Skip to content

Add nodeSelector, tolerations and affinity configuration on the component level #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gjumic-optiva
Copy link

What this PR does / why we need it

  • Adds additional configuration on the component level like nginx and railsserver deployments/pods

Let's say we have use case:

  1. 2x k8s worker nodes
  2. 2x nginx replicas
  3. 2x railsserver replicas

With current release you are unable to set the podAntiAffinity rules to have 1x nginx and 1x railsserver on Node 1, and other 2 pods one Node 2

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped

@@ -137,6 +137,30 @@ zammadConfig:
# my-label: "value"
podAnnotations: {}
# my-annotation: "value"
nodeSelector: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you're on it, can you please sort the YAML keys alphabetically?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the ones I added? I reused the same order as it was for common ones.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice for all of them :)

Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 23, 2025
@monotek
Copy link
Member

monotek commented Jun 23, 2025

Can you please rebase the pr and put your changes in the right order?

@gjumic-optiva gjumic-optiva force-pushed the component_level_config branch from 73c06a5 to 6c8eddd Compare June 23, 2025 10:06
Signed-off-by: Goran Jumic <[email protected]>
Signed-off-by: Goran Jumic <[email protected]>
Signed-off-by: Goran Jumic <[email protected]>
@gjumic-optiva
Copy link
Author

Can you please rebase the pr and put your changes in the right order?

Should be done

@monotek
Copy link
Member

monotek commented Jun 23, 2025

Can you please rebase the pr and put your changes in the right order?

Should be done

As far as I can see it's still not sorted in the values and the resource yaml files?

@github-actions github-actions bot removed the stale label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants