-
Notifications
You must be signed in to change notification settings - Fork 74
Add nodeSelector, tolerations and affinity configuration on the component level #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -137,6 +137,30 @@ zammadConfig: | |||
# my-label: "value" | |||
podAnnotations: {} | |||
# my-annotation: "value" | |||
nodeSelector: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while you're on it, can you please sort the YAML keys alphabetically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the ones I added? I reused the same order as it was for common ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice for all of them :)
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Can you please rebase the pr and put your changes in the right order? |
… level Signed-off-by: Goran Jumic <[email protected]>
73c06a5
to
6c8eddd
Compare
Signed-off-by: Goran Jumic <[email protected]>
Signed-off-by: Goran Jumic <[email protected]>
Signed-off-by: Goran Jumic <[email protected]>
Should be done |
As far as I can see it's still not sorted in the values and the resource yaml files? |
What this PR does / why we need it
Let's say we have use case:
With current release you are unable to set the podAntiAffinity rules to have 1x nginx and 1x railsserver on Node 1, and other 2 pods one Node 2
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]